Actually you are right about the expansion volume. I think the rule for sizing of expansion tanks in solar systems is to do regular sizing plus the collector volume. That only applies if the collector is above the tank. But that still doesn't resolve the location.
Open mindedness =/= parroting what you read somewhere without questioning and understanding why. Companies make mistakes or weird decisions. World-wide leaders in the car industry decided to put the gas tank right in front of the rear bumper and all the Pintos went up in flames during a crash. Larger and profitable company =/= always makes good decisions.
And as you see above, the very same company also shows the expansion tank on the pump suction side.
Every solar system has a check valve to prevent thermo-siphoning. Some pumps have it built in. So that doesn't explain why they show it 2 different ways. The above picture also has a check valve shown despite the expansion tank being on pump suction side.
If there is a valid reason to put the tank on the discharge side for solar system, I will be the first one to do that. But so far we haven't learned what the reason is and why it should be better than the suction side. If I planned to use the Caleffi solar station, I would contact them and inquire. I'm sure they have an answer. I have experienced that I contacted companies with questions like that and they admitted to being wrong in their documentation. Trust, but verify.