×
INTELLIGENT WORK FORUMS
FOR ENGINEERING PROFESSIONALS

Are you an
Engineering professional?
Join Eng-Tips Forums!
• Talk With Other Members
• Be Notified Of Responses
• Keyword Search
Favorite Forums
• Automated Signatures
• Best Of All, It's Free!

*Eng-Tips's functionality depends on members receiving e-mail. By joining you are opting in to receive e-mail.

#### Posting Guidelines

Promoting, selling, recruiting, coursework and thesis posting is forbidden.

# Nested For Next loops not working

## Nested For Next loops not working

(OP)
Here is the code as entered into my MACRO. When I Run the macro the For q = loop will not repeat. The For p = loop will cycle as many times as required, the last 3 cell inputs verify the values of q, p and the cell value in D14 of "Price list". Can anyone spot a flaw in the logic of my MACRO or is it impossible to nest for next loops.

Any help is appreciated.

Dim q As Long
Dim p As Long
Dim t As Long
For q = 1 To Worksheets("Price list").Range("d14")
For p = 1 To Worksheets("price list").Range("Cutlist_elements")(1, q)
t = t + 1
Cells(t + 3, 1) = "input data"
Cells(t + 3, 2) = "input data"
Cells(t + 3, 4) = "input data"
Cells(t + 3, 6) = "input data"
Cells(t + 3, 9) = "input data"
Cells(t + 3, 10) = q  {confirmation for debugging}
Cells(t + 3, 11) = p  {confirmation for debugging}
Cells(t + 3, 12) = Worksheets("price list").Range("d14")  {confirmation for debugging}
Next p
Next q
End Sub

### RE: Nested For Next loops not working

what does that 1,q do?

Cheers

Greg Locock

### RE: Nested For Next loops not working

Greg,
The (1,q) is similar to the Offset method, but with the difference that it is a relative reference: (1,q) refers to the same row and the q-th column. So it is equal to .Offset(0,q-1)

bpeirson,
I got your code to work without modifications. The error I made when setting up the spreadsheet is that the range "cutlist_elements" must be in a horizontal range (I first set it up in a column).
The other thing that happens with your code is that you'll quickly overwrite range [D14], dependent on the value of q and the values in  Cutlist_elements.
Remember that the (1,q) notation, as well as the Cells(t+3,1) etc, is always (row, column).
So your code is ok, it seems.

Column   A    B    C    D    E
Row14            q =    3
Row15
Row16    1    4    2    4    5

with the name Cutlist_elements defined as:
='Price list'!$A$16:$E$16

Cheers,
Joerd

Please see FAQ731-376 for tips on how to make the best use of Eng-Tips.

### RE: Nested For Next loops not working

(OP)
Thanks Joerd.

For some reason I transposed the (1,q). Should be (q,1) for the configuration of my data.

Overwriting D14 will not be a problem because this macro does not write data to the Price list worksheet.

The loops work fine now but the information written to the cells is not what was expected. But that's a different problem.

#### Red Flag This Post

Please let us know here why this post is inappropriate. Reasons such as off-topic, duplicates, flames, illegal, vulgar, or students posting their homework.

#### Red Flag Submitted

Thank you for helping keep Eng-Tips Forums free from inappropriate posts.
The Eng-Tips staff will check this out and take appropriate action.

#### Resources

Low-Volume Rapid Injection Molding With 3D Printed Molds
Learn methods and guidelines for using stereolithography (SLA) 3D printed molds in the injection molding process to lower costs and lead time. Discover how this hybrid manufacturing process enables on-demand mold fabrication to quickly produce small batches of thermoplastic parts. Download Now
Examine how the principles of DfAM upend many of the long-standing rules around manufacturability - allowing engineers and designers to place a partâ€™s function at the center of their design considerations. Download Now
Taking Control of Engineering Documents
This ebook covers tips for creating and managing workflows, security best practices and protection of intellectual property, Cloud vs. on-premise software solutions, CAD file management, compliance, and more. Download Now

Close Box

# Join Eng-Tips® Today!

Join your peers on the Internet's largest technical engineering professional community.
It's easy to join and it's free.

Here's Why Members Love Eng-Tips Forums:

• Talk To Other Members
• Notification Of Responses To Questions
• Favorite Forums One Click Access
• Keyword Search Of All Posts, And More...

Register now while it's still free!