I also call BS. I see a variety of recommendations from manufacturers and OEMs that would lead to the premature failure of their products as well.
I went to research coil spring failure today and found this article from the british Automobile Association
Coil Spring Failure Season
Their empirical evidence suggests that road salt induced corrosion is the source of spring steel failure, perhaps some materials engineers can confirm or invalidate that claim, but they state:
Hydrogen embrittlement
Electrolytic action between the salt solution, formed by road salting, and the iron in the spring generates free hydrogen atoms which enter the steel and can cause microscopic cracking. Cracks propagate and combine, ultimately leading to failure of the spring.
I would also note that most coil springs are coated, plated, or painted in some way to reduce or eliminate corrosion.
And if I am not mistaken greases are hydrophobic - meaning they would repel salty water from the road and keep it away from the springs.
Conversely if the springs grind against each other with some grit or dirt and grease it may have an abrasive effect like lapping compound.
I believe this recommendation is made with the goal of increasing spring sales but I welcome insights from materials engineers on this report from the AA. I think the question is of a materials nature, and not a mechanical one.
-ATE